1 Guest viewing this page
Hidden 12 mos ago Post by BrokenPromise
Raw
Avatar of BrokenPromise

BrokenPromise With Rightious Hands

Member Seen 37 min ago

Off the top of my head I'm not sure how it should work on small device widths.

The current table implementation uses html/css width=100% and then it adds a horizontal scrollbar if the table content can't fit. I'm not sure if this is useful or not.

Maybe you or a bbcode expert like Exit can chime in on what they think the right trade-off would be?

What would the ideal table bbcode syntax look like? e.g. maybe table by default has width=100% but table=min has no width; it's determined by content size.


I don't use my phone to view the guild often, so I had to look just now to see what you're talking about.

It does seem kind of unintuitive to scroll tables horizontally. I looked at a fake forum post I made with BBC code and it seems like bodies of text get strung out to one line, which is sort of annoying to read. I think I'd have text move to the next line if it gets too long instead of scrolling horizontally. Though I could see some fringe cases where the table is too big to appear on a phone without a horizontal scroll. It's here if you want to try for yourself. I do think being able to tell the table if it should take up all the screen or "enough" of the screen is a neat idea. For the horizontal scrolling, maybe have a way to disable it or just have it off all the time. Maybe something like [table=hscroll] if you feel you need it. Feel free to get more opinions on that.

If anyone has a list of bbcode improvements that are curated to the ones you think are most important, I'd like to read that in general. But in the meantime I could make the table bbcode more general/useful.


There's some other BBC code that looks really weird on mobile. Sometimes paragraphs are displayed on screen in a single giant column. Like when people use indent a lot. This interest check contains several examples of what I'm talking about.

That's right @Exit, you're getting mentioned again!

But in the above case, that's a pretty creative use of tags, and I'm not sure if you're going to get the exact same result for everyone's use case.
Hidden 12 mos ago 12 mos ago Post by Exit
Raw
Avatar of Exit

Exit ✁- - - - - - -

Member Seen 32 min ago






whyisthishappeningdontlookatme




edit: I don't really know if I can actually contribute to fixing the code since I'm really just pushing things around until it looks good and I know nothing about coding a website, but I do want to point out something that BP said about bodies of text strung out in a single line. I don't know if it matters but sometimes if you're viewing the page anonymously or not signed in, the code acts differently as opposed to viewing it while you are signed in. On mobile that is. You can try viewing the same page signed in and seeing if the text is a proper paragraph again.
Hidden 12 mos ago 12 mos ago Post by Mahz
Raw
OP
Avatar of Mahz

Mahz ¯\_(ツ)_/¯

Admin Seen 9 mos ago

@BrokenPromise Thanks, good points.

I love your forumception demo. The things people build with our bbcode system are amazing.

Yeah, the horizontal scroll just doesn't work. I'm gonna get rid of it. Thanks again.

>roleplayerguild.com/topics/195384-ss/ooc

omfg the design is so good. How does Exit keep getting away with this?

Edit: Ok, I've removed the horizontal scrolling from tables but it won't go into effect until tomorrow.
1x Like Like 1x Thank Thank
Hidden 12 mos ago Post by BrokenPromise
Raw
Avatar of BrokenPromise

BrokenPromise With Rightious Hands

Member Seen 37 min ago

@Mahz Glad to be of service.

I'll test the forum on my phone when the update goes into effect.

And yea, there are some pretty cool layouts that people have made. If I had to guess how he made it I'd say trial and error or he has experience working with code like this.

I don't really know if I can actually contribute to fixing the code since I'm really just pushing things around until it looks good and I know nothing about coding a website, but I do want to point out something that BP said about bodies of text strung out in a single line. I don't know if it matters but sometimes if you're viewing the page anonymously or not signed in, the code acts differently as opposed to viewing it while you are signed in. On mobile that is. You can try viewing the same page signed in and seeing if the text is a proper paragraph again.


There is an option to scale the forum to your mobile device that changes the layout a bit. If you aren't logged in, then it defaults to this not being checked. You probably have it checked, which is causing the difference between logged in and not logged in.

Hidden 12 mos ago 12 mos ago Post by Exit
Raw
Avatar of Exit

Exit ✁- - - - - - -

Member Seen 32 min ago

There is an option to scale the forum to your mobile device that changes the layout a bit. If you aren't logged in, then it defaults to this not being checked. You probably have it checked, which is causing the difference between logged in and not logged in.


I had no idea this was a thing. I don't currently have it check but now I'm going to touch it because I'm curious.

EDIT: A quick test and it seems like it's the opposite. While logged in, if i have it checked, the text stretches beyond the usual boundary. If it's unchecked, it becomes a proper paragraph.
Hidden 12 mos ago Post by BrokenPromise
Raw
Avatar of BrokenPromise

BrokenPromise With Rightious Hands

Member Seen 37 min ago

@Exit Meanwhile on my phone, everything looks really tiny while unchecked, and checking it makes the text appear at its proper size. Interesting...
Hidden 12 mos ago Post by BrokenPromise
Raw
Avatar of BrokenPromise

BrokenPromise With Rightious Hands

Member Seen 37 min ago

Oh, another interesting little hiccup I discovered.

I was looking through my PMs, and there's an empty page that reads this:

Page is empty.
In the future I'll prevent you from landing on an empty page.
← Back to Page 1


I'm sure it's a message intended to show up when browsing forum pages, but it also show up when there's nothing in an inbox folder.
Hidden 12 mos ago Post by Kuro
Raw
Avatar of Kuro

Kuro ᴋᴇᴇᴘ ʏᴏᴜʀ ᴇʏᴇꜱ ᴏɴ / ᴛʜᴇ ʀᴏᴀᴅ ᴀʜᴇᴀᴅ

Member Seen 0-24 hrs ago

@BrokenPromise First time seeing that pop up, too. Must be something new Mahz just added in. But it's odd that it shows up in PMs vs. the forum pages, if you click through to the last pages on a section the guild has countless "blank" pages where old content should've been. The statement doesn't show up there at all.
Hidden 12 mos ago 12 mos ago Post by Exit
Raw
Avatar of Exit

Exit ✁- - - - - - -

Member Seen 32 min ago

I do not know if this will help but I'm leaving this here so you can better see the rules I'm looking at when I'm playing with our table code and to add insight to BP's comment on the 'table inside table' issue. The below table is 'bordered' so it's easier to see the layout of the individual cells and the nested table within it.


fig.1
Text in the top row not placed into a cell can be strung across the top of the table without limitation. Any text within the table but outside a cell (or row) will also appear here. This row is not bold.
Text in the top row placed IN a cell is forced BOLD and confined within cell alignment.
NORMALBOLD

This nested table will force BOLD on the following:
  • Text anywhere within this nested table
  • Text within the cell the table is nested in, even if that text is not within the nested table itself.
  • Text in any subsequent cells in the same row following the cell with the nested table.
BOLD
BOLD
edit: Text in a cell following the cell with the nested table will start from the bottom.
NORMALNORMALNORMAL




This next table is the same as above but with all borders removed. The lines that are still visible have been added without input from me.


fig.2
Text in the top row not placed into a cell can be strung across the top of the table without limitation. Any text within the table but outside a cell (or row) will also appear here. This row is not bold.
Text in the top row placed IN a cell is forced BOLD and confined within cell alignment.
NORMALBOLD

This nested table will force BOLD on the following:
  • Text anywhere within this nested table
  • Text within the cell the table is nested in, even if that text is not within the nested table itself.
  • Text in any subsequent cells in the same row following the cell with the nested table.
BOLD
BOLD
edit: Text in a cell following the cell with the nested table will start from the bottom.
NORMALNORMALNORMAL




If I have any request or suggestion about tables that I think would improve its use, I believe it would be absolutely amazing to have all these automatically added lines removed. I spend a lot of time trying to cover them up and there are certain lines I can do nothing about. They kind of pop up in annoying places and limit what I can do with the tables. There are some interesting things I've wanted to try but cannot because these silly little white lines will poke out from behind whatever it is I'm trying to design.

Hidden 12 mos ago Post by shylarah
Raw
Avatar of shylarah

shylarah the crazy one

Member Seen 19 min ago

@BrokenPromise Exit's fancy designs sometimes do the nowrap thing when I'm viewing in a small window on a computer as well. So it's not just mobile that has that problem.
Hidden 12 mos ago Post by Lord Wraith
Raw
Avatar of Lord Wraith

Lord Wraith Thunderbringer

Member Seen 39 min ago

@Mahz is it possible to get the limits removed on tagging users in a post (I believe it's currently 10 individual tags, but it'd be nice to have something that allowed for no limit except for not sending multiple notifications for duplicate user tags within the same post)?

Additionally, is it possible to make it so that an edited tag would send a notification (Currently, if you make a mistake in typing a username, or otherwise miss a tag, if you edit it into a post, it does not send the notification)? Though admittedly, I'm not sure how this would work without resending the notification to all tagged users.
Hidden 12 mos ago Post by Mahz
Raw
OP
Avatar of Mahz

Mahz ¯\_(ツ)_/¯

Admin Seen 9 mos ago

@BrokenPromise First time seeing that pop up, too. Must be something new Mahz just added in. But it's odd that it shows up in PMs vs. the forum pages, if you click through to the last pages on a section the guild has countless "blank" pages where old content should've been. The statement doesn't show up there at all.


Yeah, I noticed this too:

- The "page is empty" screen when you click a PM tab with no messages
- The forum reports more pages of topics than there are

I assumed it was just pre-existing behavior, but I guess it's a new bug.

I didn't deliberately change any code that would cause this. I think when I transformed the code to modernize it that some functions return slightly different results than what they used to.

@Exit: Let me look into how I can remove all borders from tables (unless you opt in). The current table behavior doesn't make sense.

@Lord Wraith What's the use-case for creating so many tag notifications?

I do agree about letting you create a @mention notification from an edit though. Though I would probably start off by only sending a notification for edits within 30min or something finite like that.
Hidden 12 mos ago Post by Lord Wraith
Raw
Avatar of Lord Wraith

Lord Wraith Thunderbringer

Member Seen 39 min ago

@Lord Wraith What's the use-case for creating so many tag notifications?

I do agree about letting you create a @mention notification from an edit though. Though I would probably start off by only sending a notification for edits within 30min or something finite like that.


Two instances I've run into:

First instance, I've run RPs with upwards of twenty players and when doing mass acceptances or even just tagging people from interest check to OOC thread.

Second instance, doing player awards in the said RPs, these posts often well exceed ten tags.

That said, I'm aware both instances could be bypassed by multiple posts, or just not using tags, but unless I'm missing something, if there some sort of harm in having more than ten tags in a post?
Hidden 12 mos ago Post by Mahz
Raw
OP
Avatar of Mahz

Mahz ¯\_(ツ)_/¯

Admin Seen 9 mos ago

@Lord Wraith There's no harm when done honestly. I just think of things from an abuse perspective where it's good practice to set a finite limit on everything.

Also, creating notifications has historically had bad performance (it requires one trip to the database per notification created) but I am working on a fix so that notifications can be created in a bulk insert query: github.com/danneu/guild/pull/242

When this is tested and merged, I'll at least bump up the notification limit from 10 to 20. I can bump it up to 30 if you think it would help.
Hidden 12 mos ago Post by Lord Wraith
Raw
Avatar of Lord Wraith

Lord Wraith Thunderbringer

Member Seen 39 min ago

@Lord Wraith There's no harm when done honestly. I just think of things from an abuse perspective where it's good practice to set a finite limit on everything.

Also, creating notifications has historically had bad performance (it requires one trip to the database per notification created) but I am working on a fix so that notifications can be created in a bulk insert query: github.com/danneu/guild/pull/242

When this is tested and merged, I'll at least bump up the notification limit from 10 to 20. I can bump it up to 30 if you think it would help.


I was honestly going to suggest a cap of twenty. Realistically, I can't see too many use cases where it would exceed that.
1x Thank Thank
Hidden 12 mos ago Post by Exit
Raw
Avatar of Exit

Exit ✁- - - - - - -

Member Seen 32 min ago

Let me look into how I can remove all borders from tables (unless you opt in). The current table behavior doesn't make sense.

TY!

Hidden 12 mos ago Post by BrokenPromise
Raw
Avatar of BrokenPromise

BrokenPromise With Rightious Hands

Member Seen 37 min ago

@Mahz I'm not sure if you held off on the update or not, but tables still scroll on mobile.
Hidden 12 mos ago Post by Mahz
Raw
OP
Avatar of Mahz

Mahz ¯\_(ツ)_/¯

Admin Seen 9 mos ago

@BrokenPromise Yeah, it's still in the deploy queue since I packaged the 1-line change with much bigger changes that I'm testing manually.
1x Like Like
Hidden 12 mos ago Post by Exit
Raw
Avatar of Exit

Exit ✁- - - - - - -

Member Seen 32 min ago

Hi. Something changed. My tables are dying and I didn't do anything to them. Did we push an update through?
Hidden 12 mos ago 12 mos ago Post by Mahz
Raw
OP
Avatar of Mahz

Mahz ¯\_(ツ)_/¯

Admin Seen 9 mos ago

Ok, I tried to make some bbcode table changes.

- No more borders
- First row isn't bold anymore

But it involved removing default table CSS that may worsen tables, so I had to add back some behavior:

- Cells inside a table have an 8px padding (same as before)
- I'm probably missing more things here that I need to add back.

(I pushed like 3 updates in a few minutes to fix broken builds so make sure you're evaluating the latest update)
1x Thank Thank
↑ Top
1 Guest viewing this page
© 2007-2026
BBCode Cheatsheet