Mahz

Mahz's Dev Journal

@Exit I won't change [sub] behavior just yet, but we should think of coming up with specialized bbcode for specialized behavior instead of relying on unintentional quirks. That way, it's less likely to break in the future. e.g. I can't guarantee that sub tag styling will never change.

For example, if you want to be able to position something in X/Y space, I could invent something like this:

[layout=200x200]
[at=20x10]Hello[/at]
[at=50x20]World[/at]
[at=30x30]Goodbye[/at]
[/layout]
In other words: "Create a fixed-size 200x200 box that lets me position things inside it with x/y coords using the [at] tag."



(White border added for clarity)

Mahz's Dev Journal

@Exit I think you are the only person we're gonna get here that can give me this sort of feedback.

Ok, I see the cause of the regression in some behavior.

1. Looks like the old table specified a line-height for table cells. If I add it, the subbed text stops wrapping over itself:



2. I will also update the bordered-table code so that it only applies to its direct child cells instead of all descendent cells.

Thanks.

Is that new image behavior? And did I miss any other new behavior in your post that might need to be fixed?

Mahz's Dev Journal

@Mjolnir Yeah, the line break behavior is so annoying.

I think it's preserving every line break you make in bbcode, so the only way to avoid it is so put your bbcode on the same line. Awful

I think the solution is for me to tweak the bbcode system to ignore linebreaks between things like rows and cells and also ignore leading/trailing line breaks inside [cell] a [/cell].

Mahz's Dev Journal

@BrokenPromise Can you elaborate? Did the color picker color palette used to show something on hover?

Mahz's Dev Journal

@BrokenPromise When you save a post, it also saves the html that your bbcode generated to the database so that I don't break old posts if I ever change the bbcode output.

So it's intended behavior.

As for text floating off the side of the screen, that is the trade-off of removing horizontal scroll.

I'd need feedback from mobile users to figure out what the right trade-off is.

Mahz's Dev Journal

@Exit I see, so there's a regression now in the:

>BOLD edit: Text in a cell following the cell with the nested table will start from the bottom.

Now all cell content is anchored at the top.

This is because the first table row (thead) had special behavior like bold text and bottom alignment (instead of top alignment like the rest of the table). This behavior went away when I stopped special-casing the first table row.

Mahz's Dev Journal

It looks like in tables now, that items within cells are vertically aligning center rather than fixed to the top. So that's throwing off some of my coding.

@Mjolnir

Oh thanks, I see the problem. Gimme 5 min. Edit: Done

Mahz's Dev Journal

@Exit Tell me if it's crap. I used your table example above on the development server as a test case.

But your advanced bbcode might rely on bits of the original table behavior that I may have to add back individually.

Mahz's Dev Journal

Ok, I tried to make some bbcode table changes.

- No more borders
- First row isn't bold anymore

But it involved removing default table CSS that may worsen tables, so I had to add back some behavior:

- Cells inside a table have an 8px padding (same as before)
- I'm probably missing more things here that I need to add back.

(I pushed like 3 updates in a few minutes to fix broken builds so make sure you're evaluating the latest update)

Mahz's Dev Journal

@BrokenPromise Yeah, it's still in the deploy queue since I packaged the 1-line change with much bigger changes that I'm testing manually.