Mahz

Mahz's Dev Journal

Okay, I recounted the post-count on all topics to re-include hidden posts in their count.

I think it might have fixed the issues for now. Tho lemme know.

I'll keep post-deletion turned off til I figure out a game-plan.

Mahz's Dev Journal

I'll have to revert my patch from yesterday and then recount the post-counts for all topics to reconsider hidden posts so that pagination works again.

BRB

Mahz's Dev Journal

Okay, I think I figured out why this happens.

I changed the code yesterday so that, when a post is hidden, the topic recounts its post counts to ignore the newly hidden posts.

However, the pagination system expects hidden posts to be reflected in those counts because hidden posts actually take up a spot on the page.

Thanks for bringing this to my attention. I'll think of a fix.

(I temporarily turned off post hiding til I fix this to avoid further issues)

Mahz's Dev Journal

@NarayanK Lemme check it out.

Mahz's Dev Journal

Just another failure of the visitor messages system.

This is just here because the site told me so.

@Dodi do 900

Are you talking about the message above the "Bio" on your profile?

To prevent spam, the forum now requires you to have an avatar before you can edit your bio. I should've limited it so that it only requires this of new users, though.

I'm guessing that's what you're talking about.

Mahz's Dev Journal

@Altered Tundra It's not hard. The forum doesn't track it at all right now, though. But it's also harder than one might think.

For performance, you would probably append a row to a `topic_views` table on every topic view. And then at some interval (like once every 15 min) you would count the `topic_views` for each topic, update the `topics` table to add to the view count of each topic, and then delete the counted rows from `topic_views`.

@Etcetera Thanks. Yeah, for performance, there are always X posts per page of a topic, even if some of them are hidden.

However, as you found out, the bug is that a hidden post can overflow onto its own page. Since nobody can see the hidden post, you essentially have a blank page or an inaccessible one.

The quickfix is probably to redirect back a page if the current page has no hidden posts.

Mahz's Dev Journal

@Etcetera Thanks, I'll look into it.

Hello all!

Welcome

Mahz's Dev Journal

@Etcetera I increased it to 1 hour since I announced the feature.